Hi Sakari, Thanks for your work. On 2020-09-30 17:48:11 +0300, Sakari Ailus wrote: > Earlier it was expected that there would be more variable size endpoint > properties and that most if not all drivers would need them. For that > reason it was expected also that v4l2_fwnode_endpoint_parse would no > longer be needed. > > What actually happened that not all drivers require "link-frequencies", > the only variable size media endpoint property without a small upper > limit. Therefore drivers that do not need that information are fine using > v4l2_fwnode_endpoint_parse. So don't tell drivers to use > v4l2_fwnode_endpoint_alloc_parse in all cases. > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > --- > include/media/v4l2-fwnode.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/media/v4l2-fwnode.h b/include/media/v4l2-fwnode.h > index 0c28dc11e829..cbd872e59f8e 100644 > --- a/include/media/v4l2-fwnode.h > +++ b/include/media/v4l2-fwnode.h > @@ -245,8 +245,8 @@ struct v4l2_fwnode_connector { > * The function does not change the V4L2 fwnode endpoint state if it fails. > * > * NOTE: This function does not parse properties the size of which is variable > - * without a low fixed limit. Please use v4l2_fwnode_endpoint_alloc_parse() in > - * new drivers instead. > + * without a low fixed limit. Please use v4l2_fwnode_endpoint_alloc_parse() if > + * you need properties of variable size. > * > * Return: %0 on success or a negative error code on failure: > * %-ENOMEM on memory allocation failure > -- > 2.27.0 > > -- Regards, Niklas Söderlund