On Thu, Sep 17, 2020 at 01:49:41PM +0300, Dan Carpenter wrote: > On Thu, Sep 17, 2020 at 01:33:43PM +0300, Sakari Ailus wrote: > > > + int i, ret; > > > > unsigned int i > > > > Why? > > For list iterators then "int i;" is best... For sizes then unsigned is > sometimes best. Or if it's part of the hardware spec or network spec > unsigned is best. Otherwise unsigned variables cause a ton of bugs. > They're not as intuitive as signed variables. Imagine if there is an > error in this loop and you want to unwind. With a signed variable you > can do: > > while (--i >= 0) > cleanup(&bridge.sensors[i]); Ha-ha. It's actually a counter argument to your stuff because above is the same as while (i--) cleanup(&bridge.sensors[i]); with pretty much unsigned int i. > There are very few times where raising the type maximum from 2 billion > to 4 billion fixes anything. -- With Best Regards, Andy Shevchenko
