Re: [PATCH v4 2/3] media: i2c: ov772x: Add support for BT656 mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello!

On 13.09.2020 21:42, Lad Prabhakar wrote:

Add support to read the bus-type for V4L2_MBUS_BT656 and
enable BT656 mode in the sensor if needed.

   Isn't it called BT.656?

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
Reviewed-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
---
  drivers/media/i2c/ov772x.c | 27 +++++++++++++++++++++------
  1 file changed, 21 insertions(+), 6 deletions(-)

diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c
index 551082aa7026..edd7c4c22225 100644
--- a/drivers/media/i2c/ov772x.c
+++ b/drivers/media/i2c/ov772x.c
[...]
@@ -1427,16 +1434,24 @@ static int ov772x_probe(struct i2c_client *client)
  		goto error_clk_put;
  	}
- bus_cfg.bus_type = V4L2_MBUS_PARALLEL;
+	bus_cfg = (struct v4l2_fwnode_endpoint)
+		  { .bus_type = V4L2_MBUS_BT656 };
  	ret = v4l2_fwnode_endpoint_alloc_parse(ep, &bus_cfg);
  	priv->bus_type = bus_cfg.bus_type;
  	v4l2_fwnode_endpoint_free(&bus_cfg);
  	if (ret) {
-		/* For backward compatibility with the existing DT where
-		 * bus-type isnt specified fallback to V4L2_MBUS_PARALLEL
-		 */
-		priv->bus_type = V4L2_MBUS_PARALLEL;
-		dev_notice(&client->dev, "Falling back to V4L2_MBUS_PARALLEL mode\n");
+		bus_cfg.bus_type = V4L2_MBUS_PARALLEL;
+		ret = v4l2_fwnode_endpoint_alloc_parse(ep, &bus_cfg);
+		priv->bus_type = bus_cfg.bus_type;
+		v4l2_fwnode_endpoint_free(&bus_cfg);
+		if (ret) {
+			/* For backward compatibility with the existing DT where
+			 * bus-type isnt specified fallback to V4L2_MBUS_PARALLEL
                                    ^^^^ isn't
   Could be fixed, while at it?

+			 */
+			priv->bus_type = V4L2_MBUS_PARALLEL;
+			dev_notice(&client->dev,
+				   "Falling back to V4L2_MBUS_PARALLEL mode\n");
+		}
  	}
ret = ov772x_video_probe(priv);

MBR, Sergei



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux