Hi Laurent,
On 19/08/2020 01:22, Laurent Pinchart wrote:
> The max9286 driver depends on the GPIO library, list the dependency in
> Kconfig.
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Fixes: 66d8c9d2422d ("media: i2c: Add MAX9286 driver")
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
Sakari has already posted a fix for this on the 3rd August at:
[PATCH 1/1] max9286: Depend on OF_GPIO
https://lore.kernel.org/linux-media/20200803090935.23619-1-sakari.ailus@xxxxxxxxxxxxxxx/
However he chose to depend upon OF_GPIO.
I think in this instance, his patch is more correct as this particular
issue is regarding the setting of the of_node on the GPIO component,
which is guarded by CONFIG_OF_GPIO in the headers, thus I believe we can
have GPIOLIB && !OF_GPIO, which would still leave compile breakage with
your patch.
--
Regards
Kieran
> ---
> drivers/media/i2c/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index 48ae60a2c603..70ba6ca1b912 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -466,6 +466,7 @@ config VIDEO_VPX3220
>
> config VIDEO_MAX9286
> tristate "Maxim MAX9286 GMSL deserializer support"
> + depends on GPIOLIB
> depends on I2C && I2C_MUX
> depends on OF
> select V4L2_FWNODE
>
