Re: [PATCH] drivers/media/video: avoid NULL dereference

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 21 Mar 2010 22:31:06 +0100 (CET) Julia Lawall <julia@xxxxxxx> wrote:

> From: Julia Lawall <julia@xxxxxxx>
> 
> If ov is NULL, it will not be possible to take the lock in the first place,
> so move the test up earlier.
> 
> ...
>
> --- a/drivers/media/video/ov511.c
> +++ b/drivers/media/video/ov511.c
> @@ -5913,14 +5913,12 @@ ov51x_disconnect(struct usb_interface *intf)
>  
>  	PDEBUG(3, "");
>  
> +	if (!ov)
> +		return;
> +
>  	mutex_lock(&ov->lock);
>  	usb_set_intfdata (intf, NULL);
>  
> -	if (!ov) {
> -		mutex_unlock(&ov->lock);
> -		return;
> -	}
> -
>  	/* Free device number */
>  	ov511_devused &= ~(1 << ov->nr);

I think we can pretty safely assume that we never get here with ov==NULL.

Oh well, I'll leave the test there for others to ponder.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux