I noticed that the utils do not compile in C++98 mode as v4l2-test-buffers.cpp includes <atomic>, which is a C++11+ header. Ran the codebase through clang-tidy and modernized the code slightly. Rosen Penev (8): fix GCC enum warning [clang-tidy] convert to range based loops [clang-tidy] use auto [clang-tidy] use using instead of typedef [clang-tidy] use emplace_back [clang-tidy] convert files to reference [clang-tidy] fix mismatching declarations [clang-tidy] use explicit for single argument constructors lib/include/libdvbv5/atsc_eit.h | 4 +- lib/include/libdvbv5/cat.h | 4 +- lib/include/libdvbv5/descriptors.h | 2 +- lib/include/libdvbv5/dvb-demux.h | 2 +- lib/include/libdvbv5/dvb-dev.h | 2 +- lib/include/libdvbv5/dvb-fe.h | 2 +- lib/include/libdvbv5/dvb-file.h | 4 +- lib/include/libdvbv5/dvb-scan.h | 16 +-- lib/include/libdvbv5/eit.h | 4 +- lib/include/libdvbv5/header.h | 4 +- lib/include/libdvbv5/mgt.h | 4 +- lib/include/libdvbv5/mpeg_pes.h | 2 +- lib/include/libdvbv5/nit.h | 6 +- lib/include/libdvbv5/pat.h | 4 +- lib/include/libdvbv5/pmt.h | 4 +- lib/include/libdvbv5/sdt.h | 4 +- lib/include/libdvbv5/vct.h | 4 +- lib/include/libv4l2.h | 2 +- lib/libdvbv5/parse_string.h | 2 +- lib/libv4lconvert/libv4lconvert-priv.h | 48 ++++---- .../processing/libv4lprocessing.h | 2 +- lib/libv4lconvert/tinyjpeg.h | 2 +- utils/cec-compliance/cec-compliance.cpp | 2 +- utils/cec-compliance/cec-test.cpp | 57 +++++---- utils/cec-ctl/cec-ctl.cpp | 34 +++--- utils/cec-follower/cec-follower.cpp | 6 +- utils/cec-follower/cec-processing.cpp | 12 +- utils/common/v4l-helpers.h | 2 +- utils/common/v4l-stream.h | 4 +- utils/keytable/bpf.h | 6 +- utils/libcecutil/cec-info.cpp | 24 ++-- utils/libcecutil/cec-log.cpp | 12 +- utils/libmedia_dev/get_media_devices.c | 6 +- utils/rds-ctl/rds-ctl.cpp | 18 ++- utils/v4l2-compliance/v4l2-compliance.cpp | 10 +- utils/v4l2-compliance/v4l2-test-buffers.cpp | 19 ++- utils/v4l2-compliance/v4l2-test-formats.cpp | 14 +-- utils/v4l2-compliance/v4l2-test-media.cpp | 7 +- utils/v4l2-ctl/v4l2-ctl-common.cpp | 115 ++++++++---------- utils/v4l2-ctl/v4l2-ctl-overlay.cpp | 4 +- utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 9 +- utils/v4l2-ctl/v4l2-ctl-vidcap.cpp | 4 +- utils/v4l2-ctl/v4l2-ctl.cpp | 8 +- utils/v4l2-dbg/v4l2-dbg.cpp | 7 +- 44 files changed, 243 insertions(+), 265 deletions(-) -- 2.26.2