RE: [PATCH v2] v4l: videobuf: code cleanup.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>> Aguirre, Sergio wrote:
>>> Make videobuf pass checkpatch; minor code cleanups.
>>
>>I thought this kind patches were frowned upon..
>>
>>http://www.mjmwired.net/kernel/Documentation/development-process/4.Coding#41
>>
>>But maybe it's acceptable in this case... I'm not an expert on community
>> policies :)
>
> Hm, right...
> I'm not an expert either, but it does seem reasonable. It was just a part
> of the
> roadmap we agreed on in Norway, so I simply went ahead with it. Merging
> with other
> patches would pollute them so I just posted it separately. I will leave
> the
> decision up to Mauro then. I have some more "normal" patches lined up,
> so please let me know. I'm guessing we are cancelling the clean-up then
> though.

As I said, you give up way too easily. There are good reasons for doing a
simple straightforward cleanup patch first before tackling all the more
complex issues. Let's get this in first, then the future patches will only
do the actual functional changes instead of them having to do codingstyle
cleanups at the same time. I want to avoid that.

Regards,

        Hans

-- 
Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux