On Tue, 2020-06-30 at 17:23 +0200, Dafna Hirschfeld wrote: > > On 26.06.20 14:22, Philipp Zabel wrote: > > Hi Dafna, > > > > On Mon, 2020-06-08 at 12:00 +0200, Hans Verkuil wrote: > > [...] > > > > diff --git a/include/uapi/linux/v4l2-mediabus.h b/include/uapi/linux/v4l2-mediabus.h > > > > index 123a231001a8..0f916278137a 100644 > > > > --- a/include/uapi/linux/v4l2-mediabus.h > > > > +++ b/include/uapi/linux/v4l2-mediabus.h > > > > @@ -16,6 +16,8 @@ > > > > #include <linux/types.h> > > > > #include <linux/videodev2.h> > > > > > > > > +#define V4L2_MBUS_FRAMEFMT_SET_CSC 0x0001 > > > > + > > > > /** > > > > * struct v4l2_mbus_framefmt - frame format on the media bus > > > > * @width: image width ^^^^^ this one > > > > @@ -36,7 +38,8 @@ struct v4l2_mbus_framefmt { > > > > __u16 ycbcr_enc; > > > > __u16 quantization; > > > > __u16 xfer_func; > > > > - __u16 reserved[11]; > > > > + __u16 flags; > > > > + __u16 reserved[10]; > > > > }; > > > > The the flags field should also be added to the kerneldoc comment. > > Hi, Which kerneldoc comment do you mean? > I added to the doc of the v4l2-mbus-framefmt: See above, I meant the comment right above the structure definition. regards Philipp