Hi Dafna, On Mon, 2020-06-08 at 12:00 +0200, Hans Verkuil wrote: [...] > > diff --git a/include/uapi/linux/v4l2-mediabus.h b/include/uapi/linux/v4l2-mediabus.h > > index 123a231001a8..0f916278137a 100644 > > --- a/include/uapi/linux/v4l2-mediabus.h > > +++ b/include/uapi/linux/v4l2-mediabus.h > > @@ -16,6 +16,8 @@ > > #include <linux/types.h> > > #include <linux/videodev2.h> > > > > +#define V4L2_MBUS_FRAMEFMT_SET_CSC 0x0001 > > + > > /** > > * struct v4l2_mbus_framefmt - frame format on the media bus > > * @width: image width > > @@ -36,7 +38,8 @@ struct v4l2_mbus_framefmt { > > __u16 ycbcr_enc; > > __u16 quantization; > > __u16 xfer_func; > > - __u16 reserved[11]; > > + __u16 flags; > > + __u16 reserved[10]; > > }; The the flags field should also be added to the kerneldoc comment. > > > > #ifndef __KERNEL__ > > diff --git a/include/uapi/linux/v4l2-subdev.h b/include/uapi/linux/v4l2-subdev.h > > index 5d2a1dab7911..972e64d8b54e 100644 > > --- a/include/uapi/linux/v4l2-subdev.h > > +++ b/include/uapi/linux/v4l2-subdev.h > > @@ -65,6 +65,8 @@ struct v4l2_subdev_crop { > > __u32 reserved[8]; > > }; > > > > +#define V4L2_SUBDEV_MBUS_CODE_CSC_YCBCR_ENC 0x00000001 > > +#define V4L2_SUBDEV_MBUS_CODE_CSC_QUANTIZATION 0x00000002 > > /** > > * struct v4l2_subdev_mbus_code_enum - Media bus format enumeration > > * @pad: pad number, as reported by the media API > > @@ -77,7 +79,8 @@ struct v4l2_subdev_mbus_code_enum { > > __u32 index; > > __u32 code; > > __u32 which; > > - __u32 reserved[8]; > > + __u32 flags; > > + __u32 reserved[7]; > > }; Same as above. regards Philipp