Re: [PATCH] v4l2-ctl: Fix test_ioctl cmd type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



ping

On Thu, Jun 11, 2020 at 11:34:14AM +0900, Paul Elder wrote:
> test_ioctl uses int for the ioctl cmd, while it should be unsigned long.
> Fix this.
> 
> Signed-off-by: Paul Elder <paul.elder@xxxxxxxxxxxxxxxx>
> ---
>  utils/v4l2-ctl/v4l2-ctl.cpp | 2 +-
>  utils/v4l2-ctl/v4l2-ctl.h   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/utils/v4l2-ctl/v4l2-ctl.cpp b/utils/v4l2-ctl/v4l2-ctl.cpp
> index e7b270cd..4972591e 100644
> --- a/utils/v4l2-ctl/v4l2-ctl.cpp
> +++ b/utils/v4l2-ctl/v4l2-ctl.cpp
> @@ -306,7 +306,7 @@ static void usage_all()
>         edid_usage();
>  }
>  
> -int test_ioctl(int fd, int cmd, void *arg)
> +int test_ioctl(int fd, unsigned long cmd, void *arg)
>  {
>  	return options[OptUseWrapper] ? v4l2_ioctl(fd, cmd, arg) : ioctl(fd, cmd, arg);
>  }
> diff --git a/utils/v4l2-ctl/v4l2-ctl.h b/utils/v4l2-ctl/v4l2-ctl.h
> index b31be7f5..28e50471 100644
> --- a/utils/v4l2-ctl/v4l2-ctl.h
> +++ b/utils/v4l2-ctl/v4l2-ctl.h
> @@ -300,7 +300,7 @@ typedef struct {
>  
>  // v4l2-ctl.cpp
>  int doioctl_name(int fd, unsigned long int request, void *parm, const char *name);
> -int test_ioctl(int fd, int cmd, void *arg);
> +int test_ioctl(int fd, unsigned long cmd, void *arg);
>  int parse_subopt(char **subs, const char * const *subopts, char **value);
>  __u32 parse_field(const char *s);
>  __u32 parse_colorspace(const char *s);
> -- 
> 2.25.1
> 



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux