Re: [PATCH v10 1/4] dt-bindings: media: i2c: Add bindings for Maxim Integrated MAX9286

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rob,

On Mon, Jun 15, 2020 at 09:02:28AM -0600, Rob Herring wrote:
> On Sat, Jun 13, 2020 at 6:28 AM Jacopo Mondi <jacopo@xxxxxxxxxx> wrote:
> >
> > Hi Rob,
> >
> > On Fri, Jun 12, 2020 at 04:10:03PM -0600, Rob Herring wrote:
> > > On Fri, 12 Jun 2020 15:47:10 +0100, Kieran Bingham wrote:
> > > > From: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> > > >
> > > > The MAX9286 deserializes video data received on up to 4 Gigabit
> > > > Multimedia Serial Links (GMSL) and outputs them on a CSI-2 port using up
> > > > to 4 data lanes.
> > > >
> > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> > > > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>
> > > > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
> > > > Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> > > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> > > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> > > >
> > > > ---
> > > >
> > > > v7:
> > > >  - Collect Rob's RB tag
> > > >  - Remove redundant maxItems from remote-endpoints
> > > >  - Fix SPDX licence tag
> > > >
> > > > v10:
> > > > [Jacopo]
> > > >  - Fix dt-validation
> > > >  - Fix dt-binding examples with 2 reg entries
> > > >
> > > > [Kieran]
> > > >  - Correctly match the hex camera node reg
> > > >  - Add (required) GPIO controller support
> > > >
> > > >  .../bindings/media/i2c/maxim,max9286.yaml     | 366 ++++++++++++++++++
> > > >  1 file changed, 366 insertions(+)
> > > >  create mode 100644 Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> > > >
> > >
> > >
> > > My bot found errors running 'make dt_binding_check' on your patch:
> > >
> > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/maxim,max9286.example.dt.yaml: example-0: i2c@e66d8000:reg:0: [0, 3865935872, 0, 64] is too long
> > >
> > >
> > > See https://patchwork.ozlabs.org/patch/1308280
> > >
> > > If you already ran 'make dt_binding_check' and didn't see the above
> > > error(s), then make sure dt-schema is up to date:
> > >
> > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
> > >
> >
> > I have updated my dt-schema installation to the latest github master
> > -------------------------------------------------------------------------------
> > Successfully installed dtschema-2020.6.dev8+g4d2d86c
> >
> > https://github.com/devicetree-org/dt-schema/commit/4d2d86c5cd65cd3944ce0aaa400866bc36727bea
> >
> > $ /usr/bin/dt-validate -V
> > 2020.6.dev8+g4d2d86c
> > -------------------------------------------------------------------------------
> >
> > But I still cannot reproduce the error.
> >
> > However, I see this commit in your next branch
> > https://github.com/devicetree-org/dt-schema/commit/b72500282cfd2eba6f9df4d7553f696544b40ee6
> > "schemas: Add a schema to check 'reg' sizes "
> >
> > Which sounds very likely related to the above reported error.
> > Was this intentional ?
>
> Yes, I can't add the new checks to master until all the in tree schema
> are fixed yet I want to check submissions with pending checks, so I
> created the 'next' branch.

I see, makes sense. Can I just suggest to add a few words about this
new branch in the automated reply ? Otherwise the ones who are not aware
of this (like I was) will keep wondering why they don't see the error your
bot reported even if they have updated their dt-schema version to the
latest available master.

>
> > I'm not sure how I should handle this. The error reports the i2c node
> > parents should have both address-cells and size-cells properties set
> > to 2, but in the example there is not i2c node parent at all :)
> > Should I add a parent node for the i2c in the example snippet ?
>
> The examples have default sizes of 1 cell. If you need something
> different, the example has to define a parent node to specify it. In
> your case, I'd just change 'reg' to use 1 cell each.
>

Thanks, will fix.


> Rob



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux