On Mon, Jun 15, 2020 at 10:30 AM Dongchun Zhu <dongchun.zhu@xxxxxxxxxxxx> wrote: > On Fri, 2020-06-12 at 20:49 +0200, Tomasz Figa wrote: > > On Fri, Jun 12, 2020 at 11:33 AM Dongchun Zhu <dongchun.zhu@xxxxxxxxxxxx> wrote: ... > > [1] https://www.kernel.org/doc/html/latest/driver-api/gpio/consumer.html#the-active-low-and-open-drain-semantics > > > > Thank you for the sharing. > If driver only focus on the logical function of GPIO pins, > 'n_rst_gpio' may need to be renamed back to the 1st version 'rst_gpio'. Yes, we should not have any of n_* GPIOs, they must be marked as Active Low. -- With Best Regards, Andy Shevchenko