Re: [PATCH v2] media: s3c-camif: Fix missing disable in tegra_adma_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> "pm_runtime_enable()" was not handled by "pm_runtime_disable()"
> after a call of the function “pm_runtime_get_sync()” failed.
> Thus move the jump target “err_pm” before calling function
> "calling pm_runtime_disable()".

I find such a change description still improvable (also according to
the shown combination of quotation characters).


> ---
>
> V2: improving commit messages.

You proposed a slightly different wording variant.


> ---
>  drivers/media/platform/s3c-camif/camif-core.c | 2 +-

I suggest to delete the triple dashes before this diffstat.


I would find it nicer if you would put mail addresses from patch reviewers (like me)
also directly into the message field “Cc”.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=caffb99b6929f41a69edbb5aef3a359bf45f3315#n515

Regards,
Markus




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux