On Tue, May 12, 2020 at 2:12 PM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Tue, May 12, 2020 at 1:21 PM Mauro Carvalho Chehab > <mchehab@xxxxxxxxxx> wrote: > > Em Sat, 2 May 2020 20:33:14 +0300 > > Andy Shevchenko <andy.shevchenko@xxxxxxxxx> escreveu: > > > On Sat, May 2, 2020 at 8:04 PM Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> wrote: > > > > Em Sat, 2 May 2020 19:08:36 +0300 > > > > Andy Shevchenko <andy.shevchenko@xxxxxxxxx> escreveu: ... > Btw, https://git.linuxtv.org/mchehab/experimental.git/commit/?h=atomisp_v2.1&id=65608aa8d34ea274600ab2cf6f0cf54ee86d8fd1 > is incorrect approach. Look closer what PCI does in case when > pcim_enable_device() has been called. This has resource leaks https://git.linuxtv.org/mchehab/experimental.git/commit/?h=atomisp_v2.1&id=88b03de5d705f5f46a896dbd21ef9472030bb8d3 Easier just to acpi_handle_info(ACPI_HANDLE(...), ...); We don't enumerate them w/o ACPI IIRC. P.S. Yes, I understand that is WIP, but better to get rid of unnecessary / incorrect work from the day 1 :-) -- With Best Regards, Andy Shevchenko