On Fri, Apr 03, 2020 at 11:28:52AM +0100, Lad, Prabhakar wrote:
> On Fri, Apr 3, 2020 at 11:23 AM Dave Stevenson
> <dave.stevenson@xxxxxxxxxxxxxxx> wrote:
> >
> > Hi Dafna
> >
> > Thanks for the patch.
> >
> > On Tue, 31 Mar 2020 at 19:06, Dafna Hirschfeld
> > <dafna.hirschfeld@xxxxxxxxxxxxx> wrote:
> > >
> > > When enumerating the frame sizes, the value sent to
> > > imx219_get_format_code should be fse->code
> > > (the code from the ioctl) and not imx219->fmt.code
> > > which is the code set currently in the driver.
> > >
> > > Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@xxxxxxxxxxxxx>
> >
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> > Agreed that v4l2-ctl --list-formats-ext doesn't list the frame sizes
> > for the mode that isn't selected without this patch. With this patch
> > you get the full list.
> >
> > Does it warrant a "Fixes: 22da1d56e ("media: i2c: imx219: Add support
> > for RAW8 bit bayer format")"? I'd probably say yes.
> >
> +1
Thanks, all!
I've added:
Fixes: 22da1d56e982 ("media: i2c: imx219: Add support for RAW8 bit bayer format")
--
Sakari Ailus
