Hi Dafna
Thanks for the patch.
On Tue, 31 Mar 2020 at 19:06, Dafna Hirschfeld
<dafna.hirschfeld@xxxxxxxxxxxxx> wrote:
>
> When enumerating the frame sizes, the value sent to
> imx219_get_format_code should be fse->code
> (the code from the ioctl) and not imx219->fmt.code
> which is the code set currently in the driver.
>
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@xxxxxxxxxxxxx>
Agreed that v4l2-ctl --list-formats-ext doesn't list the frame sizes
for the mode that isn't selected without this patch. With this patch
you get the full list.
Does it warrant a "Fixes: 22da1d56e ("media: i2c: imx219: Add support
for RAW8 bit bayer format")"? I'd probably say yes.
Reviewed-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>
> ---
> drivers/media/i2c/imx219.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
> index b1f30debe449..df2a6ed7c8ac 100644
> --- a/drivers/media/i2c/imx219.c
> +++ b/drivers/media/i2c/imx219.c
> @@ -781,7 +781,7 @@ static int imx219_enum_frame_size(struct v4l2_subdev *sd,
> if (fse->index >= ARRAY_SIZE(supported_modes))
> return -EINVAL;
>
> - if (fse->code != imx219_get_format_code(imx219, imx219->fmt.code))
> + if (fse->code != imx219_get_format_code(imx219, fse->code))
> return -EINVAL;
>
> fse->min_width = supported_modes[fse->index].width;
> --
> 2.17.1
>
