On 20-04-28 09:55, Maxime Ripard wrote: > On Mon, Apr 27, 2020 at 05:13:42PM +0200, Robert Foss wrote: > > On Wed, 15 Apr 2020 at 18:21, Marco Felsch <m.felsch@xxxxxxxxxxxxxx> wrote: > > > > > > On 20-04-15 11:07, Rob Herring wrote: > > > > On Wed, Apr 08, 2020 at 01:08:14PM +0200, Robert Foss wrote: > > > > > From: Dongchun Zhu <dongchun.zhu@xxxxxxxxxxxx> ... > > > > > + clock-names: > > > > > + description: > > > > > + Input clock for the sensor. > > > > > + items: > > > > > + - const: xvclk > > > > > + > > > > > + assigned-clocks: > > > > > + description: > > > > > + Input clock for the sensor. > > > > > + > > > > > + assigned-clock-rates: > > > > > + description: > > > > > + Frequency of the xvclk clock in Hertz. > > > > > > > > These 2 should have a 'maxItems: 1' > > > > > > Don't know why those properties are needed here.. IMHO this shouldn't be > > > part of the binding or at least it should be optional and not required. > > > All we need is the clocks and the clock-names property. > > > > Thanks Marco, I'll make it optional for the next revision. > > Well, the whole discussion we had was about removing them entirely? +1 from my side. It is part of the system integration and not part of this device. Regards, Marco > Maxime