On Thu, Mar 04, 2010 at 08:26:23PM +0100, Uwe Kleine-König wrote: > Hi Guennadi, > > On Thu, Mar 04, 2010 at 06:13:38PM +0100, Guennadi Liakhovetski wrote: > > > +#undef DMA_BASE > > > +#define DMA_BASE MX1_IO_ADDRESS(MX1_DMA_BASE_ADDR) > > > > I don't like this. Why the "undef"? Is DMA_BASE already defined? where and > > what is it? If it is - we better use a different name, if not - just > > remove the undef, please. > yes, it's not pretty, but I wanted to make a minimal patch. > > arch/arm/plat-mxc/include/mach/dma-mx1-mx2.h has: > > #define DMA_BASE IO_ADDRESS(DMA_BASE_ADDR) This is only used in the mx1 camera driver, so you can just remove it from dma-mx1-mx2.h and use MX1_IO_ADDRESS(MX1_DMA_BASE_ADDR) in the camera driver. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
