Hi Guennadi, On Thu, Mar 04, 2010 at 06:13:38PM +0100, Guennadi Liakhovetski wrote: > > +#undef DMA_BASE > > +#define DMA_BASE MX1_IO_ADDRESS(MX1_DMA_BASE_ADDR) > > I don't like this. Why the "undef"? Is DMA_BASE already defined? where and > what is it? If it is - we better use a different name, if not - just > remove the undef, please. yes, it's not pretty, but I wanted to make a minimal patch. arch/arm/plat-mxc/include/mach/dma-mx1-mx2.h has: #define DMA_BASE IO_ADDRESS(DMA_BASE_ADDR) so that was used before. I don't really know the driver, just made it compile again. If you have a nice suggestion, I will happily implement it. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
