Hello Paul, On Mon, 2020-04-20 at 17:29 +0200, Paul Kocialkowski wrote: > Hi Ezequiel, > > On Fri 03 Apr 20, 09:21, Ezequiel Garcia wrote: > > On Fri, 2020-04-03 at 10:22 +0200, Paul Kocialkowski wrote: > > > Hi Ezequiel, > > > > > > On Thu 02 Apr 20, 16:46, Ezequiel Garcia wrote: > > > > The driver is perfectly capable of being built without CONFIG_OF. > > > > Remove this dependency, which is useful for compile-only tests. > > > > > > Thanks for the patch! > > > > > > Alas, the driver won't do anything useful without OF enabled, so it seems > > > useful to keep that dependency. > > > > I'm not convinced about this argument, I like to have > > dependencies on things the driver needs to compile > > (except the machine option, see below). > > Is there a general kernel-wide policy about that? > I don't think there is. > I must admit that I never really understood if Kconfig depends are supposed to > strictly reflect build dependencies or dependencies that must reasonably be > expected for the driver to be useful. The arch dependency (which is farily > common) seems to suggest the latter. > Indeed, it's a good point. Just forget this patch :-) As a note, some drivers use something like (ARCH_FOO && OF) || COMPILE_TEST to allow compile testing in the absence of OF support, if that's something that you care for. I do think the ARCH_SUNXI dependency makes sense. Thanks, Ezequiel
