Hi Hans, On 4/20/20 5:48 PM, Hans Verkuil wrote: > On 20/04/2020 16:38, Stanimir Varbanov wrote: >> Hi, >> >> I need to port a decoder v4l2 control in mainline Venus driver which >> instructs the decoder to decode sync frames only (I frame/ IDR frame). >> In practice the usage of such control is to generate thumbnails for >> particular video. >> >> To do that I researched what we have currently in v4l2-controls.h and >> found something similar but for encoders: >> >> V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME >> "Force a key frame for the next queued buffer. Applicable to encoders. >> This is a general, codec-agnostic keyframe control." >> >> I think I have two options: >> >> 1. reuse V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME for the decoder and document it >> >> 2. create a new v4l control V4L2_CID_MPEG_VIDC_VIDEO_SYNC_FRAME_DECODE > > Make a new v4l control. The encoder control is for something quite different. > > How about V4L2_CID_MPEG_VIDEO_DEC_KEY_FRAMES_ONLY? What you mean by "_DEC_" in the name - DECODER or DECODE? I've found V4L2_CID_MPEG_VIDEO_DECODER_SLICE_INTERFACE and V4L2_CID_MPEG_VIDEO_DECODER_MPEG4_DEBLOCK_FILTER in v4l2-controls.h which use the whole word "DECODER", thus I wonder what is proffered word to follow the v4l2-controls.h naming style. -- regards, Stan
