On Tue, Mar 31, 2020 at 4:43 PM Fabio Estevam <festevam@xxxxxxxxx> wrote: > On Tue, Mar 31, 2020 at 10:37 AM Robert Foss <robert.foss@xxxxxxxxxx> wrote: > > > After testing this change, it breaks the driver during probing. > > Why exactly does it break probing? Maybe the GPIO polarity defined in > the device tree is wrong? > > > I had a quick look into GPIOD_OUT_HIGH & LOW definitions, and they > > seem to never be 0 or 1. > > If you do a grep in all gpiod_set_value_cansleep() usages in the > kernel tree, there is not a single case where GPIOD_OUT_HIGH or > GPIOD_OUT_LOW is passed as argument of gpiod_set_value_cansleep(). +1. It simple reveals the problem that is somewhere else. -- With Best Regards, Andy Shevchenko
