On Tue, Feb 23, 2010 at 2:53 AM, Hans Verkuil <hverkuil@xxxxxxxxx> wrote: > OK. So the problem is that v4l2-ctl uses G/S_EXT_CTRLS for non-user controls, > right? Why not change v4l2-ctl: let it first try the EXT version but if that > fails with EINVAL then try the old control API. Well, that's what I'm trying to figure out. If this is a bug and I just need to fix v4l2-ctl, then I can do that. At this point, I was just trying to figure out how everybody else does private controls, since this appears to be broken out-of-the-box. > Hmm, Mauro is right: the color controls we have now are a bit of a mess. > Perhaps this is a good moment to try and fix them. Suppose we had no color > controls at all: how would we design them in that case? When we know what we > really need, then we can compare that with what we have and figure out what > we need to do to make things right again. Ok, this whole thread started because a client hit a specific quality issue, and in order to address that issue I need to expose a single slider to userland so that this advanced user can twiddle the knob with v4l2-ctl. I, perhaps naively, assumed this would be a trivial change since we already have lots of infrastructure for this and the driver in question is quite mature. So we've gone from what I thought was going to be a six line change in g_ctrl/s_ctrl to converting the whole driver over to using the extended controls interface, to now the suggestion that we redesign the way we do color controls across the entire v4l2 subsystem? I don't dispute that the way things have ended up is not ideal (and presumably got that way because of the diversity of different decoders we support and the differences in the underlying registers they provide). But at this point, I'm trying to solve what should be a rather simple problem, and I haven't been contracted to redesign the entire subsystem just to expose one advanced control. So if people agree this is a bug in v4l2-ctl, then I'll dig into that block of code and submit a patch. If the real problem is that the saa7115 driver needs to be converted to the extended control interface to expose a single private control, well I can do that instead (although I think that would be a pretty dumb limitation). At this point, I'm just trying to find the simplest change required to accomplish something that should have taken me half an hour and been done two days ago. Devin -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html