在 2020/1/14 1:34, Helen Koike 写道:
Hi Zhang,
Thank you for the patch.
On 1/13/20 1:48 AM, Zhang Xiaoxu wrote:
If 'GENERIC_PHY_MIPI_DPHY' not configured, there is an error:
drivers/staging/media/rkisp1/rkisp1-isp.o:
In function `rkisp1_mipi_csi2_start.isra.5':
rkisp1-isp.c:(.text+0x1238):
undefined reference to `phy_mipi_dphy_get_default_config'
make: *** [vmlinux] Error 1
Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@xxxxxxxxxx>
---
drivers/staging/media/rkisp1/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/rkisp1/Kconfig b/drivers/staging/media/rkisp1/Kconfig
index b859a493caba..788bcb703376 100644
--- a/drivers/staging/media/rkisp1/Kconfig
+++ b/drivers/staging/media/rkisp1/Kconfig
@@ -8,6 +8,7 @@ config VIDEO_ROCKCHIP_ISP1
select VIDEOBUF2_VMALLOC
select V4L2_FWNODE
select PHY_ROCKCHIP_DPHY_RX0
+ select GENERIC_PHY_MIPI_DPHY
default n
help
Enable this to support the Image Signal Processing (ISP) module
How are you reproducing this?
VIDEO_ROCKCHIP_ISP1 selects PHY_ROCKCHIP_DPHY_RX0
and
PHY_ROCKCHIP_DPHY_RX0 already selects GENERIC_PHY_MIPI_DPHY,
So it shouldn't be a problem (unless I misunderstood something, which is probably the case).
Yes, you are right.
This can be reproduce with the following config:
# CONFIG_OF is not set
#
# soc_camera sensor drivers
#
CONFIG_PHY_ROCKCHIP_DPHY_RX0=y
CONFIG_VIDEO_ROCKCHIP_ISP1=y
I think the cause of the problem is:
'CONFIG_PHY_ROCKCHIP_DPHY_RX0' should also be depended on 'CONFIG_OF'.
Thanks
Helen
