Stefan Ringel wrote: > Am 19.02.2010 17:07, schrieb Patch from Mauro Carvalho Chehab: >> } >> >> div = (freq - offset + DIV / 2) / DIV; >> @@ -1114,17 +1152,22 @@ static int xc2028_set_params(struct dvb_frontend *fe, >> >> /* All S-code tables need a 200kHz shift */ >> if (priv->ctrl.demod) { >> - demod = priv->ctrl.demod + 200; >> + /* >> + * Newer firmwares require a 200 kHz offset only for ATSC >> + */ >> + if (type == ATSC || priv->firm_version < 0x0302) >> + demod = priv->ctrl.demod + 200; >> /* >> * The DTV7 S-code table needs a 700 kHz shift. >> - * Thanks to Terry Wu <terrywu2009@xxxxxxxxx> for reporting this >> * >> * DTV7 is only used in Australia. Germany or Italy may also >> * use this firmware after initialization, but a tune to a UHF >> * channel should then cause DTV78 to be used. >> + * >> + * Unfortunately, on real-field tests, the s-code offset >> + * didn't work as expected, as reported by >> + * Robert Lowery <rglowery@xxxxxxxxxxxxxx> >> */ >> - if (type & DTV7) >> - demod += 500; >> } >> >> return generic_set_freq(fe, p->frequency, >> > Hi Mauro, > > your patch doesn't work. Here is not set demod for all others (demod=0). > For DVB to properly work, you need to fill ctrl.demod at tm6000, otherwise, demod will be 0, and it will use some default that won't likely work. -- Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html