stefan.ringel@xxxxxxxx wrote: > From: Stefan Ringel <stefan.ringel@xxxxxxxx> > > Signed-off-by: Stefan Ringel <stefan.ringel@xxxxxxxx> Why do you need to split it into two functions? It should be noticed that the naming tm6000_i2c_recv_word is wrong, since the size can be bigger than 2. Also, this patch broke compilation on -git: CC [M] drivers/staging/tm6000/tm6000-i2c.o drivers/staging/tm6000/tm6000-i2c.c: In function ‘tm6000_i2c_send_byte’: drivers/staging/tm6000/tm6000-i2c.c:50: error: ‘REQ_16_SET_GET_I2C_WR1_RND’ undeclared (first use in this function) drivers/staging/tm6000/tm6000-i2c.c:50: error: (Each undeclared identifier is reported only once drivers/staging/tm6000/tm6000-i2c.c:50: error: for each function it appears in.) drivers/staging/tm6000/tm6000-i2c.c: In function ‘tm6000_i2c_recv_byte’: drivers/staging/tm6000/tm6000-i2c.c:55: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘:’ token drivers/staging/tm6000/tm6000-i2c.c:55: error: expected expression before ‘:’ token drivers/staging/tm6000/tm6000-i2c.c:60: error: ‘rc’ undeclared (first use in this function) drivers/staging/tm6000/tm6000-i2c.c: In function ‘tm6000_i2c_recv_word’: drivers/staging/tm6000/tm6000-i2c.c:68: error: ‘REQ_14_SET_GET_I2C_WR2_RND’ undeclared (first use in this function) make[1]: ** [drivers/staging/tm6000/tm6000-i2c.o] Erro 1 Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
