>>>- if (!std_info)
>>>+ if (!std_info->stdid)
>>> return -1;
>>>
>> This is a NACK. We shouldn't check for stdid since the function is
>supposed
>> to update std_info. So just remove
>>
>> if (!std_info)
>> return -1;
>
>I don't see how std_info could get updated. consider the loop in case
>std_info->stdid equals 0:
Ok. You are right! The ch_params[] is a table for keeping the information
about different standards supported. For a given stdid in std_info, the function matches the stdid with that in the table and get the corresponding entry.
>> I am okay with the below change. So please re-submit the patch with the
>> above change and my ACK.
>>
>> Thanks
>>
>> Murali
>>
>
>>>+ if (k == VPIF_DISPLAY_MAX_DEVICES)
>>>+ k = VPIF_DISPLAY_MAX_DEVICES - 1;
>
>actually I think this is still not right. shouldn't it be be
>
>k = VPIF_DISPLAY_MAX_DEVICES - 1;
What you mean here? What you suggest here is same as in your patch, right?
Murali
>
>> are you using this driver in your project?
>
>No, I just found this in the code.
>
>Thanks, Roel
��.n��������+%������w��{.n�����{��g����^n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�m
