Re: cx23885

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2010-02-15 at 18:22 -0500, Ralph Siemsen wrote:
> On Mon, Feb 15, 2010 at 11:56:52PM +0100, Michael wrote:
> > 
> > If anybody can give me a hint, what to include in a patch and what was old 
> > stuff that has jsut changed in 2.6.31, I'd be grateful.
> 
> Their source tree contains a .hg_archival.txt file which looks like
> it can be used to identify the original v4l-dvb tree they used.
> 
> Attached is a diff from that v4l version to the MPX-885 tree.
>  cx23885/cx23885-cards.c    |   90 ++++++++++++++++
>  cx23885/cx23885-dvb.c      |   30 +++++
>  cx23885/cx23885-video.c    |    2 
>  cx23885/cx23885.h          |    1 
>  cx25840/cx25840-core.c     |  248 +++++++++++++++++++++++++++++++++++++++------
>  cx25840/cx25840-firmware.c |    4 
>  6 files changed, 338 insertions(+), 37 deletions(-)
> 
> Hope it helps...
> -R


That is very helpful.

However, changes to the CX25840 module, since their MPX885 changes were
developed, are extenesive when it comes to initialization of the
CX23885/7/8 A/V decoder.  Their changes will be difficult to port.

I also see changes which will at least break existing drivers and apps.
For example, this one will violate a key assumption made by the ivtv
driver:

-       state->vid_input = CX25840_COMPOSITE7;
+       state->vid_input = CX25840_COMPOSITE1;


This sort of thing is typical of many vendor driver developments: get it
working for this part as fast as possible so the product can ship -
don't worry about anything else.

It is still decent of them to provide a linux driver and the source
changes without a hassle.  RAR format is inconvenient on linux though.

Regards,
Andy

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux