Hi Mani, On Tue, Nov 05, 2019 at 08:33:55PM +0530, Manivannan Sadhasivam wrote: > On Mon, Nov 04, 2019 at 03:42:06PM +0200, Laurent Pinchart wrote: > > On Fri, Nov 01, 2019 at 08:22:46PM +0530, Manivannan Sadhasivam wrote: > >> On Thu, Oct 31, 2019 at 03:23:09PM +0200, Laurent Pinchart wrote: > >>> The IMX296LLR is a monochrome 1.60MP CMOS sensor from Sony. The driver > >>> supports cropping and binning (but not both at the same time due to > >>> hardware limitations) and exposure, gain, vertical blanking and test > >>> pattern controls. > >>> > >>> Preliminary support is also included for the color IMX296LQR sensor. > >>> > >>> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > >>> --- > >>> This driver is a parallel implementation of IMX296 support, compatible > >>> with the DT bindings submitted by Mani in > >>> https://lore.kernel.org/linux-media/20191030094902.32582-1-manivannan.sadhasivam@xxxxxxxxxx/. > >>> > >>> drivers/media/i2c/Kconfig | 12 + > >>> drivers/media/i2c/Makefile | 1 + > >>> drivers/media/i2c/imx296.c | 1026 ++++++++++++++++++++++++++++++++++++ > >>> 3 files changed, 1039 insertions(+) > >>> create mode 100644 drivers/media/i2c/imx296.c [snip] > >>> diff --git a/drivers/media/i2c/imx296.c b/drivers/media/i2c/imx296.c > >>> new file mode 100644 > >>> index 000000000000..4140637983fd > >>> --- /dev/null > >>> +++ b/drivers/media/i2c/imx296.c [snip] > >>> +struct imx296 { > >>> + struct device *dev; > >>> + struct clk *clk; > >>> + struct regulator *supply; > >> > >> Any plan to use 3 power supplies as discussed in bindings patch? > > > > I'd like to reach a conclusion on that discussion first :-) Do you think > > we should add them right away, or only when needed ? There's no issue > > with backward compatibility, if we start with one power supply only the > > next two would be optional. > > The use of single power supply still doesn't look good to me. Could you please > add all of them? I can give this a try. I'm annoyed that it will make my DT more complex as I have a single controllable power supply from which the three sensor supplies are derived. Could you share the sensor DT fragment for your platform to give me a second example ? [snip] -- Regards, Laurent Pinchart
