On Tue, Nov 05, 2019 at 07:24:15PM +0200, Sakari Ailus wrote:
> On Tue, Nov 05, 2019 at 08:33:55PM +0530, Manivannan Sadhasivam wrote:
> ...
> > > > > +static int imx296_remove(struct i2c_client *client)
> > > > > +{
> > > > > + struct v4l2_subdev *subdev = i2c_get_clientdata(client);
> > > > > + struct imx296 *imx = to_imx296(subdev);
> > > > > +
> > > > > + v4l2_async_unregister_subdev(subdev);
> > > > > + media_entity_cleanup(&subdev->entity);
> > > > > + v4l2_ctrl_handler_free(&imx->ctrls);
> > > > > +
> > > > > + return 0;
> > > > > +}
> > > > > +
> > > > > +#if IS_ENABLED(CONFIG_OF)
> >
> > I think you don't need this guard if of_match_ptr is used.
>
> There's also need for of_match_ptr, it should be removed.
I'll fix both.
--
Regards,
Laurent Pinchart
