Hi Rob, Sakari, On Tue, Oct 29, 2019 at 05:12:13PM -0500, Rob Herring wrote: > On Mon, Oct 28, 2019 at 02:21:15PM +0200, Sakari Ailus wrote: > > Hi Manivannan, > > > > Thanks for the update. > > > > On Fri, Oct 25, 2019 at 11:29:07PM +0530, Manivannan Sadhasivam wrote: > > > Add YAML devicetree binding for IMX296 CMOS image sensor. > > > > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > > > --- > > > .../devicetree/bindings/media/i2c/imx296.yaml | 98 +++++++++++++++++++ > > > 1 file changed, 98 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/media/i2c/imx296.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/imx296.yaml b/Documentation/devicetree/bindings/media/i2c/imx296.yaml > > > new file mode 100644 > > > index 000000000000..4e204fd7cf90 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/media/i2c/imx296.yaml > > > @@ -0,0 +1,98 @@ > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/media/i2c/imx296.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Sony IMX296 1/2.8-Inch CMOS Image Sensor > > > + > > > +maintainers: > > > + - Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > > > + > > > +description: |- > > > + The Sony IMX296 is a 1/2.9-Inch active pixel type CMOS Solid-state image > > > + sensor with square pixel array and 1.58 M effective pixels. This chip > > > + features a global shutter with variable charge-integration time. It is > > > + programmable through I2C and 4-wire interfaces. The sensor output is > > > + available via CSI-2 serial data output (1 Lane). > > > + > > > +properties: > > > + compatible: > > > + const: sony,imx296 > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + clocks: > > > + maxItems: 1 > > > + > > > + clock-names: > > > + description: > > > + Input clock for the sensor. > > > + items: > > > + - const: mclk > > > + > > > + clock-frequency: > > > + description: > > > + Frequency of the mclk clock in Hertz. > > > + default: 37125000 > > > > I think you could omit the default. > > Yes, there's no default if it is required. > Okay. > > > + > > > + vddo-supply: > > > + description: > > > + Definition of the regulator used as interface power supply. > > > + maxItems: 1 > > > + > > > + vdda-supply: > > > + description: > > > + Definition of the regulator used as analog power supply. > > > + maxItems: 1 > > > + > > > + vddd-supply: > > > + description: > > > + Definition of the regulator used as digital power supply. > > > + maxItems: 1 > > > + > > > + reset-gpios: > > > + description: > > > + The phandle and specifier for the GPIO that controls sensor reset. > > > + maxItems: 1 > > > + > > > + # See ../video-interfaces.txt for details > > details on what? > Standard properties like endpoint, reg, etc... I can remove it if not required. > > > + > > > +required: > > > + - compatible > > > + - reg > > > + - clocks > > > + - clock-names > > > + - clock-frequency > > > + - vddo-supply > > > + - vdda-supply > > > + - vddd-supply > > > > I think the port and endpoint nodes should documented here as well. > > port yes, but endpoint no. Unless you have endpoint properties other > than remote-endpoint or reg. > Okay. Will document port. Thanks, Mani > > > > > + > > > +additionalProperties: false > > > + > > > +examples: > > > + - | > > > + #include <dt-bindings/gpio/gpio.h> > > > + > > > + imx296: camera-sensor@1a { > > > + compatible = "sony,imx296"; > > > + reg = <0x1a>; > > > + reset-gpios = <&msmgpio 35 GPIO_ACTIVE_LOW>; > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&camera_rear_default>; > > > + clocks = <&gcc 90>; > > > + clock-names = "mclk"; > > > + clock-frequency = <37125000>; > > > + vddo-supply = <&camera_vddo_1v8>; > > > + vdda-supply = <&camera_vdda_3v3>; > > > + vddd-supply = <&camera_vddd_1v2>; > > > + > > > + port { > > > + imx296_ep: endpoint { > > > + remote-endpoint = <&csiphy0_ep>; > > > + }; > > > + }; > > > + }; > > > + > > > +... > > > > -- > > Regards, > > > > Sakari Ailus
