Re: [PATCHv6 0/3] v4l2-core: improve ioctl validation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 14, 2019 at 10:40:18AM +0200, Hans Verkuil wrote:
> This supersedes https://www.mail-archive.com/linux-media@xxxxxxxxxxxxxxx/msg150027.html
> based on feedback from Laurent:
> 
> https://www.mail-archive.com/linux-media@xxxxxxxxxxxxxxx/msg150117.html
> 
> and Sakari:
> 
> https://www.mail-archive.com/linux-media@xxxxxxxxxxxxxxx/msg150129.html
> 
> This v6 only moves some code from patch 1 to patch 3, the final code
> is the same as for v5. I plan to make a PR for this very soon together
> with the vivid metadata patches that need this.
> 
> Regards,
> 
> 	Hans
> 
> Changes in v6:
> 
> Patch 1/3 dropped the check against GRABBER for the g_parm ioctl,
> but that is too early: this should be done in patch 3/3 where this
> code no longer applies to touch devices (which was the reason for
> the GRABBER test).
> 
> Changes in v5:
> 
> I now check if a GRABBER device is a video or metadata device
> (or both!) by checking device_caps.
> 
> 
> Hans Verkuil (2):
>   v4l2-dev: simplify the SDR checks
>   v4l2-dev: fix is_tch checks
> 
> Vandana BN (1):
>   v4l2-core: correctly validate video and metadata ioctls

For the whole series,

Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> 
>  drivers/media/v4l2-core/v4l2-dev.c   | 104 ++++++++++++++++-----------
>  drivers/media/v4l2-core/v4l2-ioctl.c |  16 ++++-
>  2 files changed, 75 insertions(+), 45 deletions(-)
> 

-- 
Regards,

Laurent Pinchart



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux