Re: [PATCH 2/5] docs: media: vimc: Documenting vimc topology configuration using configfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello All,

W dniu 23.09.2019 o 11:50, Hans Verkuil pisze:
On 9/23/19 11:29 AM, Dafna Hirschfeld wrote:
On Fri, 2019-09-20 at 15:39 +0200, Hans Verkuil wrote:
On 9/19/19 10:32 PM, Dafna Hirschfeld wrote:
Add explanation of how to use configfs in order to create a
vimc device with a given topology.

Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@xxxxxxxxxxxxx>
---
  Documentation/media/v4l-drivers/vimc.dot |  28 ++-
  Documentation/media/v4l-drivers/vimc.rst | 240 ++++++++++++++++++++---
  2 files changed, 220 insertions(+), 48 deletions(-)


When adding new sysfs or configfs directories/files one should add
appropriate entries to Documentation/ABI/*.

My feeling is that this patch should be merged with the patch actually
enabling the configfs interface, which is patch 4/5. The reason is twofold.

The first is consistency: if a documentation for an interface is added
in a different patch than the interface itself, then at the first of the
two commits in question we either have a documentation for a non-existing
interface, or an undocumented interface.

The second is that the documentation is not only for kernel developers
but also for users who don't have the faintest idea of what code is
inside the kernel, so even though patch 3/5 of this series adds
the code implementing the interface, it is not available to users
until patch 4/5.

Regards,

Andrzej



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux