Re: [PATCH 14/15] - zl10353

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 03.02.2010 21:49, schrieb Devin Heitmueller:
> On Wed, Feb 3, 2010 at 3:38 PM, Stefan Ringel <stefan.ringel@xxxxxxxx> wrote:
>   
>> signed-off-by: Stefan Ringel <stefan.ringel@xxxxxxxx>
>>
>> --- a/drivers/media/dvb/frontends/zl10353.h
>> +++ b/drivers/media/dvb/frontends/zl10353.h
>> @@ -45,6 +45,8 @@ struct zl10353_config
>>        /* clock control registers (0x51-0x54) */
>>        u8 clock_ctl_1;  /* default: 0x46 */
>>        u8 pll_0;        /* default: 0x15 */
>> +
>> +       int tm6000:1;
>>  };
>>     
> Why is this being submitted as its own patch?  It is code that is not
> used by *anything*.  If you really did require a new field in the
> zl10353 config, that field should be added in the same patch as
> whatever requires it.
>
> Devin
>
>   
Actually doesn't work zl10353 with tm6010, it have a little different
between a few registers, so I think that I use it.

for example:
zl10353 use 0x64 , but not mine (0x63)
register 0x5f is 0x17 not 0x13
register 0x5e is 0x40 not 0x00 for auto
and tuner go is 0x70 not 0x71

the other register are ok. I have no idea how I can set it.


-- 
Stefan Ringel <stefan.ringel@xxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux