Devin Heitmueller wrote: > Hello all, > > I am doing some quality improvements for a couple of the > em28xx/saa7113 designs, and I found a pretty serious problem which > appears to have been there for some time. > > In fact, the regression was introduced when the saa7115 support was > added in 2005 (hg revision 2750). This change resulted in the > anti-alias filtering being disabled by default for the saa7113 (the > saa7115_init_misc block clears bit 7 of register 0x02). Without this > change, vertical lines appear in the chroma on a fixed interval. > > The big issue is that the driver is shared with other saa7113 > products, as well as products that have the saa7111, saa7114, and > saa7115. So I have to figure out whether to just force on the AA > filter for the saa7113, or whether it should be enabled for the > others, or whether I can even turn it on for saa7113 in general or > need to hack something in there to only do it for the two or three > products I am testing with. > > So here's where I could use some help: If you have a product that > uses one of the above chips, please speak up. I will be setting up a > test tree where people can try out the change and see if it makes > their situation better, worse, or no change. The better is to allow enabling/disabling the anti-alias via ctrl. Whatever default is chosen, the driver may adjust the control default at the board initialization, or even blocking the control when the other mode of operation is broken. I have here a few devices with saa7113 and saa7114. I think I have also one device with saa7111, but I need to check. If I'm right, it will take some time for me to prepare the saa7111 environment. The saa7113/7114 devices are easier to setup, as they are usb. -- Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
