On Saturday 30 January 2010 17:26:51 Martin Fuzzey wrote:
> Regression was caused by my commit 6b35ca0d3d586b8ecb8396821af21186e20afaf0
> which determined message size using sizeof rather than hardcoded constants.
>
> Unfortunately pwc_set_shutter_speed reuses a 2 byte buffer for a one byte
> message too so the sizeof was bogus in this case.
>
> All other uses of sizeof checked and are ok.
>
> Signed-off-by: Martin Fuzzey <mfuzzey@xxxxxxxxx>
Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
>
> ---
>
> drivers/media/video/pwc/pwc-ctrl.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/video/pwc/pwc-ctrl.c
> b/drivers/media/video/pwc/pwc-ctrl.c index 50b415e..f7f7e04 100644
> --- a/drivers/media/video/pwc/pwc-ctrl.c
> +++ b/drivers/media/video/pwc/pwc-ctrl.c
> @@ -753,7 +753,7 @@ int pwc_set_shutter_speed(struct pwc_device *pdev, int
> mode, int value) buf[0] = 0xff; /* fixed */
>
> ret = send_control_msg(pdev,
> - SET_LUM_CTL, SHUTTER_MODE_FORMATTER, &buf, sizeof(buf));
> + SET_LUM_CTL, SHUTTER_MODE_FORMATTER, &buf, 1);
>
> if (!mode && ret >= 0) {
> if (value < 0)
>
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
