On Mon, Feb 1, 2010 at 4:23 PM, Stefan Ringel <stefan.ringel@xxxxxxxx> wrote: >> You should start by breaking it down into a patch series, so that the >> incremental changes can be reviewed. That will allow you to explain >> in the patch descriptions why all the individual changes you have made >> are required. >> >> > how can I generate it? You can use quilt to break it up into a patch series, or create a local hg clone of v4l-dvb. >> Why did you define a new callback for changing the tuner mode? We >> have successfully provided infrastructure on other bridges to toggle >> GPIOs when changing modes. For example, the em28xx has fields in the >> board profile that allow you to toggle GPIOs when going back and forth >> between digital and analog mode. >> >> > I don't know, how you mean it. I'm amateur programmer. Look at how the ".dvb_gpio" and ".gpio" fields are used in the board profiles in em28xx-cards.c. We toggle the GPIOs when switching the from analog to digital mode, without the tuner having to do any sort of callback. >> What function does the "tm6000" member in the zl10353 config do? It >> doesn't seem to be used anywhere. >> >> > I'll switch it next week to demodulator module. Are you saying the zl10353 isn't working right now in your patch? I'm a bit confused. If it doesn't work, then your patch title is a bit misleading since it suggests that your patch provides DVB support for the tm6000. If it does work, then the tm6000 member shouldn't be needed at all in the zl10353 config. Cheers, Devin -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
