Am 01.02.2010 21:52, schrieb Devin Heitmueller: > On Mon, Feb 1, 2010 at 3:35 PM, Stefan Ringel <stefan.ringel@xxxxxxxx> wrote: > >> add Terratec Cinergy Hybrid XE >> bugfix i2c transfer >> add frontend callback >> add init for tm6010 >> add digital-init for tm6010 >> add callback for analog/digital switch >> bugfix usb transfer in DVB-mode >> >> signed-off-by: Stefan Ringel <stefan.ringel@xxxxxxxx> >> > Hi Stefan, > > It's good to see you're making progress. However, this is going to > need *alot* of work before it will be able to be accepted upstream. > > You should start by breaking it down into a patch series, so that the > incremental changes can be reviewed. That will allow you to explain > in the patch descriptions why all the individual changes you have made > are required. > > how can I generate it? > However, I will try to put some of my thoughts down based on the quick > glance I took at the patch. > > Why did you define a new callback for changing the tuner mode? We > have successfully provided infrastructure on other bridges to toggle > GPIOs when changing modes. For example, the em28xx has fields in the > board profile that allow you to toggle GPIOs when going back and forth > between digital and analog mode. > > I don't know, how you mean it. I'm amateur programmer. > You've got a bunch of changes in the xc3028 tuner that will > *definitely* need close inspection and would need to be validated on a > variety of products using the xc3028 before they could be accepted > upstream. While you have done what you felt was necessary to make it > work for your board, this cannot be at the cost of possible > regressions to other products that are already supported. > > You really should look into fixing whatever is screwed up in the > tm6000 i2c implementation so that the read support works, rather than > relying on nothing ever having to perform a read operation. > > What function does the "tm6000" member in the zl10353 config do? It > doesn't seem to be used anywhere. > > I'll switch it next week to demodulator module. > There are a bunch of codingstyle issues which will need to be fixed. > > My foremost concerns are obviously the things that touch other > drivers, since your work could cause regressions/breakage for other > boards, which is actually much worse than your board not being > supported. > > Cheers Stefan Ringel -- Stefan Ringel <stefan.ringel@xxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
