Re: [PATCH] soc_camera: match signedness of soc_camera_limit_side()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



You didn't reply to my most important objection:

On Wed, 27 Jan 2010, Németh Márton wrote:

> diff -r 31eaa9423f98 linux/include/media/soc_camera.h
> --- a/linux/include/media/soc_camera.h	Mon Jan 25 15:04:15 2010 -0200
> +++ b/linux/include/media/soc_camera.h	Wed Jan 27 20:49:57 2010 +0100
> @@ -264,9 +264,8 @@
>  		common_flags;
>  }
> 
> -static inline void soc_camera_limit_side(unsigned int *start,
> -		unsigned int *length, unsigned int start_min,
> -		unsigned int length_min, unsigned int length_max)
> +static inline void soc_camera_limit_side(int *start, int *length,
> +		int start_min, int length_min, int length_max)
>  {
>  	if (*length < length_min)
>  		*length = length_min;

I still do not believe this function will work equally well with signed 
parameters, as it works with unsigned ones.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux