On Wed, 27 Jan 2010, Németh Márton wrote:
> Guennadi Liakhovetski wrote:
[snip]
> > And these:
> >
> > if (output_w > max(512U, input_w / 2)) {
> > if (output_h > max(384U, input_h / 2)) {
> >
> > would now produce compiler warnings... Have you actually tried to compile
> > your patch? You'll also have to change formats in dev_dbg() calls here...
>
> Interesting to hear about compiler warnings. I don't get them if I apply the patch
> on top of version 14064:31eaa9423f98 of http://linuxtv.org/hg/v4l-dvb/ . What
> is your compiler version?
Well, it's my built-in mental compiler, I haven't started versioning it
yet;) Strange, that (your) compiler doesn't complain - max() does
type-checking and now it's signed against unsigned, hm... In any case,
that one is easy to fix - just remove the "U"s, but I'm wondering why the
compiler didn't shout and whether there can be other similar mismatches...
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
