On Sat, 23 Jan 2010, Douglas Schilling Landgraf wrote:
Removed unused variable.
Signed-off-by: Douglas Schilling Landgraf <dougsland@xxxxxxxxxx>
Thanks,
Douglas
Douglas,
Thanks for your sharp eyes.
However, I _think_ that this particular problem may have already been
fixed, recently if not some time before. In particular, recent changes
have been done in the version of sq905c.c which lives in the gspca tree of
Hans de Goede. I am working off his tree these days because we have been
doing a number of things together, and thus the changes there to sq905c.c
have been done by a patch from here.
These changes were done in order to add a couple of new cameras and to
change the way to decide whether the camera is a VGA or a CIF camera. The
determination of this by USB Product number does not always work, and one
needs to read an ID string from the camera in order to learn it better.
Who bought the camera which has the "wrong" resolution setting associated
with its USB Product number? Hans de Goede.
It appears to me that this patch is not relevant to that most recent
version of sq905c.c. At least, it does not fit here, which is where it
appears it is supposed to fit:
/* This function is called at probe time just before sd_init */
static int sd_config(struct gspca_dev *gspca_dev,
const struct usb_device_id *id)
{
struct cam *cam = &gspca_dev->cam;
struct sd *dev = (struct sd *) gspca_dev;
int ret;
PDEBUG(D_PROBE,
"SQ9050 camera detected"
If everyone else is agreeable, I would propose that the recent changes to
sq905c.c should simply be pulled, and that is the best solution to the
problem.
Hans, can you confirm all of this?
Theodore Kilgore
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
