On Sat, Jan 23, 2010 at 10:07 PM, Manu Abraham <abraham.manu@xxxxxxxxx> wrote: > Hi Andreas, > > On Sat, Jan 23, 2010 at 9:50 PM, Andreas Regel <andreas.regel@xxxxxx> wrote: >> Hi Manu, >> >> Am 22.01.2010 21:22, schrieb Manu Abraham: >>> >>> On Fri, Jan 22, 2010 at 11:40 PM, Devin Heitmueller >>> <dheitmueller@xxxxxxxxxxxxxx> wrote: >>>> >>>> Also, the dvb_frontend.c makes calls to i2c_gate_ctrl() at various >>>> points, so you would need to ensure that none of those occur before >>>> calling into your driver as there could potentially be a deadlock >>>> there too. >>> >>> Ok, thanks for the pointer. The gate control is never called >>> externally in reality. I will wait a little while for this patch to be >>> applied. It removes the exported function and thereby an unnecessary >>> dereference. >>> >>> http://jusst.de/hg/stv090x/rev/b3d28f5b2b53 >> >> There is one call to the gate control function from stv6110x_attach. This is >> needed to set up the clock output divider to the correct value before the >> demodulators clock is configured. >> >> This could be solved by calling tuner_init before setting up the master >> clock in stv090x_init but that only helps on single tuner devices. On dual >> tuner devices you can only open the adapter that works with the second >> tuner. Then you will have the case that the master clock is set without >> having the clock output divider of first tuner initialized to the correct >> value. > > Thinking of which, maybe it would be better to attach the tuner_attach > within the stv090x_attach(). That could solve the issue, AFAICT. What > do you say ? OR Another option will be to attach the tuner prior to the demodulator, without the clock configuration in the tuner attach (clk configuartion would be another function ptr), attach the demodulator, run clock configuration... I think this might be a bit more cleaner than attaching the tuner within the demodulator_attach() ... ? Regards, Manu -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
