Le mercredi 10 avril 2019 à 16:22 +0200, Philipp Zabel a écrit : > On Wed, 2019-04-10 at 15:43 +0200, Hans Verkuil wrote: > [...] > > > @@ -1126,12 +1127,32 @@ static int coda_enum_frameintervals(struct file *file, void *fh, > [...] > > Why support VIDIOC_ENUM_FRAMEINTERVALS at all? It makes no sense for a codec. > > I'd remove it altogether. It does make sense, since framerate is the only information that can be used to produce a specific bitrate. If you don't enumerate the rates, then you may endup with a miss-match of what userspace wants, which will result in a different rate then what the user-space anticipated. That being said, I expect these intervals to be really wide. Venus HW uses a Q16 internally, which is precise enough that we could just ignore the interval. > > It returns the range supported by the frame rate registers that can be > set for constant bitrate encoding. I think the idea was to let the > GStreamer v4l2 elements know about possible frame rate range. > I think I should be able to remove it without any negative effects. As long as we can still set the framerate. > > regards > Philipp
Attachment:
signature.asc
Description: This is a digitally signed message part
