On Wed, 2019-04-10 at 15:43 +0200, Hans Verkuil wrote: [...] > > @@ -1126,12 +1127,32 @@ static int coda_enum_frameintervals(struct file *file, void *fh, [...] > > Why support VIDIOC_ENUM_FRAMEINTERVALS at all? It makes no sense for a codec. > I'd remove it altogether. It returns the range supported by the frame rate registers that can be set for constant bitrate encoding. I think the idea was to let the GStreamer v4l2 elements know about possible frame rate range. I think I should be able to remove it without any negative effects. regards Philipp
