Hi Mauro, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on next-20190226] [cannot apply to v5.0-rc8] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/media-vim2m-improve-debug-messages/20190227-194011 base: git://linuxtv.org/media_tree.git master config: i386-randconfig-x001-201908 (attached as .config) compiler: gcc-8 (Debian 8.2.0-20) 8.2.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All error/warnings (new ones prefixed by >>): In file included from include/media/v4l2-subdev.h:24, from include/media/v4l2-device.h:25, from drivers/media//platform/vim2m.c:28: drivers/media//platform/vim2m.c: In function 'vim2m_buf_prepare': >> include/media/v4l2-common.h:84:13: warning: comparison between pointer and integer if (debug >= (level)) \ ^~ drivers/media//platform/vim2m.c:71:2: note: in expansion of macro 'v4l2_dbg' v4l2_dbg(lvl, debug, &dev->v4l2_dev, "%s: " fmt, __func__, ## arg) ^~~~~~~~ drivers/media//platform/vim2m.c:893:3: note: in expansion of macro 'dprintk' dprintk(ctx->dev, "%s data will not fit into plane (%lu < %lu)\n", ^~~~~~~ >> drivers/media//platform/vim2m.c:894:5: error: expected ')' before '__func__' __func__, vb2_plane_size(vb, 0), (long)q_data->sizeimage); ^~~~~~~~ include/media/v4l2-common.h:69:22: note: in definition of macro 'v4l2_printk' printk(level "%s: " fmt, (dev)->name , ## arg) ^~~ drivers/media//platform/vim2m.c:71:2: note: in expansion of macro 'v4l2_dbg' v4l2_dbg(lvl, debug, &dev->v4l2_dev, "%s: " fmt, __func__, ## arg) ^~~~~~~~ drivers/media//platform/vim2m.c:893:3: note: in expansion of macro 'dprintk' dprintk(ctx->dev, "%s data will not fit into plane (%lu < %lu)\n", ^~~~~~~ >> include/linux/kern_levels.h:5:18: warning: format '%s' expects a matching 'char *' argument [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^~~~~~ include/media/v4l2-common.h:69:9: note: in definition of macro 'v4l2_printk' printk(level "%s: " fmt, (dev)->name , ## arg) ^~~~~ include/linux/kern_levels.h:15:20: note: in expansion of macro 'KERN_SOH' #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */ ^~~~~~~~ include/media/v4l2-common.h:85:16: note: in expansion of macro 'KERN_DEBUG' v4l2_printk(KERN_DEBUG, dev, fmt , ## arg); \ ^~~~~~~~~~ drivers/media//platform/vim2m.c:71:2: note: in expansion of macro 'v4l2_dbg' v4l2_dbg(lvl, debug, &dev->v4l2_dev, "%s: " fmt, __func__, ## arg) ^~~~~~~~ drivers/media//platform/vim2m.c:893:3: note: in expansion of macro 'dprintk' dprintk(ctx->dev, "%s data will not fit into plane (%lu < %lu)\n", ^~~~~~~ include/media/v4l2-common.h:69:17: note: format string is defined here printk(level "%s: " fmt, (dev)->name , ## arg) ~^ >> include/linux/kern_levels.h:5:18: warning: format '%s' expects a matching 'char *' argument [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^~~~~~ include/media/v4l2-common.h:69:9: note: in definition of macro 'v4l2_printk' printk(level "%s: " fmt, (dev)->name , ## arg) ^~~~~ include/linux/kern_levels.h:15:20: note: in expansion of macro 'KERN_SOH' #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */ ^~~~~~~~ include/media/v4l2-common.h:85:16: note: in expansion of macro 'KERN_DEBUG' v4l2_printk(KERN_DEBUG, dev, fmt , ## arg); \ ^~~~~~~~~~ drivers/media//platform/vim2m.c:71:2: note: in expansion of macro 'v4l2_dbg' v4l2_dbg(lvl, debug, &dev->v4l2_dev, "%s: " fmt, __func__, ## arg) ^~~~~~~~ drivers/media//platform/vim2m.c:893:3: note: in expansion of macro 'dprintk' dprintk(ctx->dev, "%s data will not fit into plane (%lu < %lu)\n", ^~~~~~~ drivers/media//platform/vim2m.c:71:41: note: format string is defined here v4l2_dbg(lvl, debug, &dev->v4l2_dev, "%s: " fmt, __func__, ## arg) ~^ -- In file included from include/media/v4l2-subdev.h:24, from include/media/v4l2-device.h:25, from drivers/media/platform/vim2m.c:28: drivers/media/platform/vim2m.c: In function 'vim2m_buf_prepare': >> include/media/v4l2-common.h:84:13: warning: comparison between pointer and integer if (debug >= (level)) \ ^~ drivers/media/platform/vim2m.c:71:2: note: in expansion of macro 'v4l2_dbg' v4l2_dbg(lvl, debug, &dev->v4l2_dev, "%s: " fmt, __func__, ## arg) ^~~~~~~~ drivers/media/platform/vim2m.c:893:3: note: in expansion of macro 'dprintk' dprintk(ctx->dev, "%s data will not fit into plane (%lu < %lu)\n", ^~~~~~~ drivers/media/platform/vim2m.c:894:5: error: expected ')' before '__func__' __func__, vb2_plane_size(vb, 0), (long)q_data->sizeimage); ^~~~~~~~ include/media/v4l2-common.h:69:22: note: in definition of macro 'v4l2_printk' printk(level "%s: " fmt, (dev)->name , ## arg) ^~~ drivers/media/platform/vim2m.c:71:2: note: in expansion of macro 'v4l2_dbg' v4l2_dbg(lvl, debug, &dev->v4l2_dev, "%s: " fmt, __func__, ## arg) ^~~~~~~~ drivers/media/platform/vim2m.c:893:3: note: in expansion of macro 'dprintk' dprintk(ctx->dev, "%s data will not fit into plane (%lu < %lu)\n", ^~~~~~~ >> include/linux/kern_levels.h:5:18: warning: format '%s' expects a matching 'char *' argument [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^~~~~~ include/media/v4l2-common.h:69:9: note: in definition of macro 'v4l2_printk' printk(level "%s: " fmt, (dev)->name , ## arg) ^~~~~ include/linux/kern_levels.h:15:20: note: in expansion of macro 'KERN_SOH' #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */ ^~~~~~~~ include/media/v4l2-common.h:85:16: note: in expansion of macro 'KERN_DEBUG' v4l2_printk(KERN_DEBUG, dev, fmt , ## arg); \ ^~~~~~~~~~ drivers/media/platform/vim2m.c:71:2: note: in expansion of macro 'v4l2_dbg' v4l2_dbg(lvl, debug, &dev->v4l2_dev, "%s: " fmt, __func__, ## arg) ^~~~~~~~ drivers/media/platform/vim2m.c:893:3: note: in expansion of macro 'dprintk' dprintk(ctx->dev, "%s data will not fit into plane (%lu < %lu)\n", ^~~~~~~ include/media/v4l2-common.h:69:17: note: format string is defined here printk(level "%s: " fmt, (dev)->name , ## arg) ~^ >> include/linux/kern_levels.h:5:18: warning: format '%s' expects a matching 'char *' argument [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^~~~~~ include/media/v4l2-common.h:69:9: note: in definition of macro 'v4l2_printk' printk(level "%s: " fmt, (dev)->name , ## arg) ^~~~~ include/linux/kern_levels.h:15:20: note: in expansion of macro 'KERN_SOH' #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */ ^~~~~~~~ include/media/v4l2-common.h:85:16: note: in expansion of macro 'KERN_DEBUG' v4l2_printk(KERN_DEBUG, dev, fmt , ## arg); \ ^~~~~~~~~~ drivers/media/platform/vim2m.c:71:2: note: in expansion of macro 'v4l2_dbg' v4l2_dbg(lvl, debug, &dev->v4l2_dev, "%s: " fmt, __func__, ## arg) ^~~~~~~~ drivers/media/platform/vim2m.c:893:3: note: in expansion of macro 'dprintk' dprintk(ctx->dev, "%s data will not fit into plane (%lu < %lu)\n", ^~~~~~~ drivers/media/platform/vim2m.c:71:41: note: format string is defined here v4l2_dbg(lvl, debug, &dev->v4l2_dev, "%s: " fmt, __func__, ## arg) ~^ vim +894 drivers/media//platform/vim2m.c 96d8eab5d drivers/media/video/mem2mem_testdev.c Pawel Osciak 2010-04-23 883 ab7afaf33 drivers/media/platform/vim2m.c Hans Verkuil 2019-01-16 884 static int vim2m_buf_prepare(struct vb2_buffer *vb) ab7afaf33 drivers/media/platform/vim2m.c Hans Verkuil 2019-01-16 885 { ab7afaf33 drivers/media/platform/vim2m.c Hans Verkuil 2019-01-16 886 struct vim2m_ctx *ctx = vb2_get_drv_priv(vb->vb2_queue); ab7afaf33 drivers/media/platform/vim2m.c Hans Verkuil 2019-01-16 887 struct vim2m_q_data *q_data; ab7afaf33 drivers/media/platform/vim2m.c Hans Verkuil 2019-01-16 888 4bd10b032 drivers/media/platform/vim2m.c Mauro Carvalho Chehab 2019-02-26 889 dprintk(ctx->dev, 2, "type: %s\n", type_name(vb->vb2_queue->type)); ab7afaf33 drivers/media/platform/vim2m.c Hans Verkuil 2019-01-16 890 ab7afaf33 drivers/media/platform/vim2m.c Hans Verkuil 2019-01-16 891 q_data = get_q_data(ctx, vb->vb2_queue->type); d80ee38cd drivers/media/video/mem2mem_testdev.c Marek Szyprowski 2011-01-12 892 if (vb2_plane_size(vb, 0) < q_data->sizeimage) { d80ee38cd drivers/media/video/mem2mem_testdev.c Marek Szyprowski 2011-01-12 893 dprintk(ctx->dev, "%s data will not fit into plane (%lu < %lu)\n", d80ee38cd drivers/media/video/mem2mem_testdev.c Marek Szyprowski 2011-01-12 @894 __func__, vb2_plane_size(vb, 0), (long)q_data->sizeimage); 96d8eab5d drivers/media/video/mem2mem_testdev.c Pawel Osciak 2010-04-23 895 return -EINVAL; 96d8eab5d drivers/media/video/mem2mem_testdev.c Pawel Osciak 2010-04-23 896 } 96d8eab5d drivers/media/video/mem2mem_testdev.c Pawel Osciak 2010-04-23 897 d80ee38cd drivers/media/video/mem2mem_testdev.c Marek Szyprowski 2011-01-12 898 vb2_set_plane_payload(vb, 0, q_data->sizeimage); 96d8eab5d drivers/media/video/mem2mem_testdev.c Pawel Osciak 2010-04-23 899 96d8eab5d drivers/media/video/mem2mem_testdev.c Pawel Osciak 2010-04-23 900 return 0; 96d8eab5d drivers/media/video/mem2mem_testdev.c Pawel Osciak 2010-04-23 901 } 96d8eab5d drivers/media/video/mem2mem_testdev.c Pawel Osciak 2010-04-23 902 :::::: The code at line 894 was first introduced by commit :::::: d80ee38cd845baadef175893b99df24e7a03ec40 [media] v4l: mem2mem: port m2m_testdev to vb2 :::::: TO: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> :::::: CC: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
