Hi Ezequiel, On Fri, Feb 22, 2019 at 01:59:33PM -0300, Ezequiel Garcia wrote: > On Fri, 2019-02-22 at 16:46 +0900, Tomasz Figa wrote: > > > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > > > index 9a920f071ff9..6443ae53597f 100644 > > > --- a/include/uapi/linux/videodev2.h > > > +++ b/include/uapi/linux/videodev2.h > > > @@ -653,6 +653,7 @@ struct v4l2_pix_format { > > > #define V4L2_PIX_FMT_H264 v4l2_fourcc('H', '2', '6', '4') /* H264 with start codes */ > > > #define V4L2_PIX_FMT_H264_NO_SC v4l2_fourcc('A', 'V', 'C', '1') /* H264 without start codes */ > > > #define V4L2_PIX_FMT_H264_MVC v4l2_fourcc('M', '2', '6', '4') /* H264 MVC */ > > > +#define V4L2_PIX_FMT_H264_SLICE v4l2_fourcc('S', '2', '6', '4') /* H264 parsed slices */ > > > > Are we okay with adding here already, without going through staging first? > > Also regarding the pixel formats. I still think we should have two > pixel formats: V4L2_PIX_FMT_H264_SLICE_RAW and > V4L2_PIX_FMT_H264_SLICE_ANNEX_B, to properly represent "raw" NALUs > and "annex B" formatted NALUs. I agree with that, but I was under the impression that it would be part of your series, since you would be the prime user (at first at least). Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Attachment:
signature.asc
Description: PGP signature