Re: [PATCH 1/2] selftests: Use lirc.h from kernel tree, not from system

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/17/19 8:29 AM, Sean Young wrote:
When the system lirc.h is older than v4.16, you will get errors like:

ir_loopback.c:32:16: error: field ‘proto’ has incomplete type
   enum rc_proto proto;

Cc: Shuah Khan <shuah@xxxxxxxxxx>
Signed-off-by: Sean Young <sean@xxxxxxxx>
---
  tools/testing/selftests/ir/Makefile | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/ir/Makefile b/tools/testing/selftests/ir/Makefile
index f4ba8eb84b95..ad06489c22a5 100644
--- a/tools/testing/selftests/ir/Makefile
+++ b/tools/testing/selftests/ir/Makefile
@@ -1,5 +1,7 @@
  # SPDX-License-Identifier: GPL-2.0
  TEST_PROGS := ir_loopback.sh
  TEST_GEN_PROGS_EXTENDED := ir_loopback
+APIDIR := ../../../include/uapi
+CFLAGS += -Wall -O2 -I$(APIDIR)
include ../lib.mk


Thanks for the fix. I can take this through kselftest tree if
there are no dependencies on any media patches. It looks that
way, just confirming. It will be very likely for rc5.

thanks,
-- Shuah



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux