On Mon, 11 Jan 2010 20:24:51 +0100, Samuel Rakitnican
<samuel.rakitnican@xxxxxxxxx> wrote:
On Fri, 08 Jan 2010 13:59:14 +0100, Samuel Rakitnican
<samuel.rakitnican@xxxxxxxxx> wrote:
On Tue, 05 Jan 2010 21:11:59 +0100, Samuel Rakitničan
<samuel.rakitnican@xxxxxxxxx> wrote:
Hi,
I have an old bt878 based analog card. It's 'Hauppauge WinTV Radio'
model 44914,
rev C121.
I'm trying to workout support for this shipped remote control. I have
[...]
Card: http://linuxtv.org/wiki/index.php/File:Wintv-radio-C121.jpg
Remote: http://linuxtv.org/wiki/index.php/File:Wintv-radio-remote.jpg
Did some investigation, maybe this can help to clarify some things.
Still didn't get any response in dmesg from remote.
[...]
i2c_scan:
bttv0: i2c scan: found device @ 0x30 [IR (hauppauge)]
bttv0: i2c scan: found device @ 0xa0 [eeprom]
bttv0: i2c scan: found device @ 0xc2 [tuner (analog)]
[...]
modprobe ir-kbd-i2c debug=1
ir-kbd-i2c: probe 0x1a @ bt878 #0 [sw]: no
ir-kbd-i2c: probe 0x18 @ bt878 #0 [sw]: yes
[...]
OK, patch http://patchwork.kernel.org/patch/70126/ did the trick for
kernel oops and segfault. However there is still something wrong in the
filtering code for hauppauge remotes that prevents my remote codes for
passing through:
drivers/media/video/ir-kbd-i2c.c
99 /*
100 * Hauppauge remotes (black/silver) always use
101 * specific device ids. If we do not filter the
102 * device ids then messages destined for devices
103 * such as TVs (id=0) will get through causing
104 * mis-fired events.
105 *
106 * We also filter out invalid key presses which
107 * produce annoying debug log entries.
108 */
109 ircode= (start << 12) | (toggle << 11) | (dev << 6) | code;
110 if ((ircode & 0x1fff)==0x1fff)
111 /* invalid key press */
112 return 0;
113
114 if (dev!=0x1e && dev!=0x1f)
115 /* not a hauppauge remote */
116 return 0;
117
118 if (!range)
119 code += 64;
When I comment in this part: if (dev!=0x1e && dev!=0x1f), my remote
works with a hauppage=1 parameter, althought a few buttons are not
mapped correctly.
dmesg example with an empty table (buttons CH+ and CH-):
: unknown key: key=0x20 down=1
: unknown key for scancode 0x0020
: unknown key: key=0x20 down=0
: unknown key for scancode 0x0021
: unknown key: key=0x21 down=1
: unknown key for scancode 0x0021
: unknown key: key=0x21 down=0
Can someone please take a look at this and perhaps fix the code. Thanks
in advance.
Regards,
Samuel
It seems that my device id is the one that code author wants to filter
(0x0) if I understood correctly. I can add it to if (dev!=0x1e &&
dev!=0x1f) statement, but I then (I guess) would broke the filter
functionality:
ir-kbd-i2c: ir hauppauge (rc5): s1 r1 t1 dev=0 code=32
If this is the case the only thing I can think of is to add a module
parameter that turns off
such filtering.
What do you think?
Regards,
Samuel
diff -r 82bbb3bd0f0a linux/drivers/media/video/ir-kbd-i2c.c
--- a/linux/drivers/media/video/ir-kbd-i2c.c Mon Jan 11 11:47:33 2010 -0200
+++ b/linux/drivers/media/video/ir-kbd-i2c.c Tue Jan 12 23:36:44 2010 +0100
@@ -61,6 +61,10 @@
module_param(hauppauge, int, 0644); /* Choose Hauppauge remote */
MODULE_PARM_DESC(hauppauge, "Specify Hauppauge remote: 0=black, 1=grey
(defaults to 0)");
+static int haup_filter = 1;
+module_param(haup_filter, int, 0644);
+MODULE_PARM_DESC(haup_filter, "Turn off Hauppauge filter for other
remotes (defaults to 1)");
+
#define DEVNAME "ir-kbd-i2c"
#define dprintk(level, fmt, arg...) if (debug >= level) \
@@ -96,6 +100,8 @@
if (!start)
/* no key pressed */
return 0;
+
+ if (haup_filter != 0) {
/*
* Hauppauge remotes (black/silver) always use
* specific device ids. If we do not filter the
@@ -114,6 +120,7 @@
if (dev!=0x1e && dev!=0x1f)
/* not a hauppauge remote */
return 0;
+ }
if (!range)
code += 64;
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
