Hi Antti, On 09/01/2019 11.36, Antti Palosaari wrote: > On 12/20/18 11:57 PM, Brad Love wrote: >> Works in ATSC and QAM as is, DVB is completely untested. >> >> Firmware required. >> >> Signed-off-by: Brad Love <brad@xxxxxxxxxxxxxxxx> >> --- >> drivers/media/tuners/si2157.c | 6 ++++++ >> drivers/media/tuners/si2157_priv.h | 3 ++- > > >> #define SI2158_A20_FIRMWARE "dvb-tuner-si2158-a20-01.fw" >> #define SI2141_A10_FIRMWARE "dvb-tuner-si2141-a10-01.fw" >> - >> +#define SI2157_A30_FIRMWARE "dvb-tuner-si2157-a30-05.fw" > > Why you added 05 to that file name? I added that spare number for > cases you have to replace firmware to another for some reason thus by > default case it should be 01. > Barring any explanation of the naming convention, I made it look similar to the previous two, while reflecting the firmware version. This is firmware 3.0.5. I have no problem "starting from 1", but reflecting the firmware version seemed like the sane idea. I'll resubmit if desired. Regards, Brad > regards > Antti >
