Hi Akinobu,
On 18-12-30 02:07, Akinobu Mita wrote:
> Since commit 98480d65c48c ("media: mt9m111: allow to setup pixclk
> polarity"), the MT9M111_OUTFMT_INV_PIX_CLOCK bit in the output format
> control 2 register has to be changed depending on the pclk-sample property
> setting.
>
> Without this change, the MT9M111_OUTFMT_INV_PIX_CLOCK bit is unchanged.
I don't know what you mean, it will get applied depending on the
property.
8<------------------------------------------------------------------------
static int mt9m111_set_pixfmt(struct mt9m111 *mt9m111,
u32 code)
{
...
/* receiver samples on falling edge, chip-hw default is rising */
if (mt9m111->pclk_sample == 0)
mask_outfmt2 |= MT9M111_OUTFMT_INV_PIX_CLOCK;
...
}
8<------------------------------------------------------------------------
Isn't this right?
Can you cc me the other patches too, so I can keep track of it easier?
Regards,
Marco
>
> Fixes: 98480d65c48c ("media: mt9m111: allow to setup pixclk polarity")
> Cc: Enrico Scholz <enrico.scholz@xxxxxxxxxxxxxxxxx>
> Cc: Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx>
> Cc: Marco Felsch <m.felsch@xxxxxxxxxxxxxx>
> Cc: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
> Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>
> ---
> drivers/media/i2c/mt9m111.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/i2c/mt9m111.c b/drivers/media/i2c/mt9m111.c
> index d639b9b..f0e47fd 100644
> --- a/drivers/media/i2c/mt9m111.c
> +++ b/drivers/media/i2c/mt9m111.c
> @@ -542,6 +542,7 @@ static int mt9m111_set_pixfmt(struct mt9m111 *mt9m111,
> {
> struct i2c_client *client = v4l2_get_subdevdata(&mt9m111->subdev);
> u16 data_outfmt2, mask_outfmt2 = MT9M111_OUTFMT_PROCESSED_BAYER |
> + MT9M111_OUTFMT_INV_PIX_CLOCK |
> MT9M111_OUTFMT_BYPASS_IFP | MT9M111_OUTFMT_RGB |
> MT9M111_OUTFMT_RGB565 | MT9M111_OUTFMT_RGB555 |
> MT9M111_OUTFMT_RGB444x | MT9M111_OUTFMT_RGBx444 |
> --
> 2.7.4
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
